Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

49 finalize jones pupil to fits file conversion #101

Merged
merged 11 commits into from
Dec 22, 2023

Conversation

kenjim21
Copy link
Collaborator

jones_to_fits function created with corresponding demo

@kenjim21 kenjim21 linked an issue Dec 22, 2023 that may be closed by this pull request
@kenjim21 kenjim21 requested a review from Jashcraf December 22, 2023 19:10
Copy link

codecov bot commented Dec 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a15947c) 93.11% compared to head (ea52576) 93.48%.
Report is 20 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #101      +/-   ##
==========================================
+ Coverage   93.11%   93.48%   +0.36%     
==========================================
  Files           3        4       +1     
  Lines         247      261      +14     
==========================================
+ Hits          230      244      +14     
  Misses         17       17              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@Jashcraf Jashcraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for adding this feature :)

@Jashcraf Jashcraf merged commit 1dd292c into main Dec 22, 2023
3 checks passed
@Jashcraf Jashcraf deleted the 49-finalize-jones-pupil-to-fits-file-conversion branch December 26, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Finalize Jones Pupil to FITS file conversion
2 participants